Merged
Conversation
Implement the Shell interface for bash, adding tab completion via COMP_WORDS/COMPREPLY with -o nosort -o nospace flags. Update docs, install script, and CLI flag values to include bash alongside fish and zsh.
There was a problem hiding this comment.
Pull request overview
This PR adds bash shell completion support to the fetch CLI tool, implementing the Shell interface for bash alongside the existing fish and zsh implementations.
Changes:
- Implements Bash struct with Register() and Complete() methods using COMP_WORDS/COMPREPLY
- Adds "bash" as a valid value for the --complete flag
- Updates documentation and install script with bash completion instructions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/complete/shells.go | Adds Bash struct implementing Shell interface with completion logic |
| internal/complete/complete_test.go | Adds comprehensive test cases for bash completion scenarios |
| internal/cli/cli_test.go | Adds test to verify flags are in alphabetical order |
| internal/cli/app.go | Reorders flags alphabetically and adds "bash" to --complete flag values |
| install.sh | Adds bash completion installation to .bashrc |
| docs/getting-started.md | Documents bash completion setup command |
| docs/cli-reference.md | Updates --complete flag documentation to include bash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Shell interface for bash, adding tab completion via COMP_WORDS/COMPREPLY with
-o nosort -o nospaceflags. Update docs, install script, and CLI flag values to include bash alongside fish and zsh.