style: Resolve ansible-lint warnings across all playbooks#20
Merged
ryanspletzer merged 2 commits intomainfrom Mar 1, 2026
Merged
style: Resolve ansible-lint warnings across all playbooks#20ryanspletzer merged 2 commits intomainfrom
ryanspletzer merged 2 commits intomainfrom
Conversation
- yaml[truthy]: Replace `yes` with `true` for all YAML truthy values (gather_facts, become, update_cache, upgrade, etc.) - ignore-errors: Replace `ignore_errors: yes` with `failed_when: false` for more precise error suppression - schema[playbook]: Use fully qualified `ansible.builtin.sudo` for become_method - command-instead-of-shell: Use `command` instead of `shell` for the Homebrew cask install task (no shell features needed) Remove yaml[truthy], ignore-errors, and schema[playbook] from the ansible-lint warn_list since all violations are now resolved. Future violations will fail the build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The WSL check uses `uname -r | grep` intentionally with non-zero exit codes as data (0=not WSL, 1=WSL1, 2=WSL2). Adding pipefail would break this logic. The previous `ignore_errors: yes` implicitly suppressed this rule; `failed_when: false` does not, so an explicit noqa is needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yeswithtruefor all YAML truthy values across all 4 Ansible playbooksignore_errors: yeswithfailed_when: falsefor more precise error suppression (22 occurrences; 2 tasks in macOS that already hadfailed_when: falsejust had the redundantignore_errorsremoved)become_method: ansible.builtin.sudo(2 occurrences in macOS)commandinstead ofshellfor the Homebrew cask install task (no shell features needed)yaml[truthy],ignore-errors, andschema[playbook]from.ansible-lintwarn_list— all violations resolved, future violations will now fail the buildTest plan
warn_listrules (command-instead-of-shell, etc.) still produce warnings without failing🤖 Generated with Claude Code