fix: Resolve remaining ansible-lint warnings and enforce all rules#21
Merged
ryanspletzer merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
Replace git config commands with community.general.git_config module, add FQCN and name to meta task, break long Jinja2 lines with folded scalars, add changed_when to custom command/script tasks, and suppress rules where shell or command usage is intentional. Remove warn_list from .ansible-lint — all rules now enforced at error level. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git config --globalcommands withcommunity.general.git_configmodule across all 4 playbooksansible.builtin.meta) andname:to themeta: refresh_inventorytask (macOS)>-folded block scalars (ubuntu/debian/fedora)register+changed_when+failed_whento custom command and script tasks (ubuntu/debian/fedora)command-instead-of-moduleongit lfs installtasks (no Ansible module exists for git-lfs)command-instead-of-shellon custom command tasks (shell intentionally needed for arbitrary user commands)warn_listfrom.ansible-lint— all 7 rules now enforced at error levelTest plan
validatejob passes with zero warnings/annotationsgit configstill applied correctly viacommunity.general.git_configmodule🤖 Generated with Claude Code