Updated to Meteor 1.3 & native npm packages#3
Open
NilsDannemann wants to merge 1 commit intoryanswapp:masterfrom
Open
Updated to Meteor 1.3 & native npm packages#3NilsDannemann wants to merge 1 commit intoryanswapp:masterfrom
NilsDannemann wants to merge 1 commit intoryanswapp:masterfrom
Conversation
Owner
|
Hey thanks for doing this! I'm trying to decide the best way to proceed since updating the code necessarily requires updating the written blog post. I think I'm going to wait to pull this in until I can update the blog post. Hopefully I'll have some time this weekend :) |
Author
|
No worries. Hopefully updating it isn't too much work. I've literally just added the npm packages (phantomjs & webshot), replaced require with imports and moved the method out of the isServer block and put it in the server-folder instead. Oh, and I had to lock the webshot npm version. Everything else exactly like you created it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an final_updated folder, which updates the tutorial to Meteor 1.3 and native npm packages.
Had to lock the webshot npm version, since the newest seems to have some problems with bootstrap.