Skip to content

Modify custom Nginx config for OIDC Discovery support - #1126

Open
Harry-Chen wants to merge 2 commits into
rybbit-io:masterfrom
Harry-Chen:patch-1
Open

Modify custom Nginx config for OIDC Discovery support#1126
Harry-Chen wants to merge 2 commits into
rybbit-io:masterfrom
Harry-Chen:patch-1

Conversation

@Harry-Chen

@Harry-Chen Harry-Chen commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

#1107 has added some but missed another nginx configuration item.

Summary by CodeRabbit

  • Documentation
    • Clarified that the .well-known route supports OIDC Discovery.
    • Updated custom Nginx configuration guidance to route both API and .well-known requests to the backend.

Updated Nginx configuration to include OIDC Discovery path.
Copilot AI lite review requested due to automatic review settings August 19, 2026 04:55
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

@Harry-Chen is attempting to deploy a commit to the goldflag's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dc59d431-fa8d-4c5c-bce7-736d6cdc07b7

📥 Commits

Reviewing files that changed from the base of the PR and between dd5dd3b and b41a9c6.

📒 Files selected for processing (1)
  • docs/content/docs/(docs)/self-hosting-guides/custom-nginx.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/content/docs/(docs)/self-hosting-guides/custom-nginx.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The custom Nginx guide documents OIDC Discovery support and routes both /api/ and /.well-known/ requests to the backend.

Changes

Custom Nginx OIDC routing

Layer / File(s) Summary
Document and route OIDC Discovery
docs/content/docs/(docs)/self-hosting-guides/custom-nginx.mdx
The guide documents .well-known as the OIDC Discovery path. The custom backend location pattern includes /api/ and /.well-known/.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b41a9

This is a localized documentation update for custom Nginx OIDC Discovery support, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related PRs

  • rybbit-io/rybbit#1107: Updates the same custom Nginx configuration to route /.well-known/ requests to the backend.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating custom Nginx configuration to support OIDC Discovery.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the self-hosting “custom Nginx” guide to ensure OAuth/OIDC discovery endpoints under /.well-known/* are proxied to the backend (matching the MCP client’s auto-discovery expectations), including the custom-port configuration example.

Changes:

  • Documented that /.well-known/* should be forwarded to the backend for OIDC discovery.
  • Updated the custom-ports Nginx snippet to proxy both /api/* and /.well-known/* to the backend.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/content/docs/(docs)/self-hosting-guides/custom-nginx.mdx Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants