Add include_all optional parameter to respond_to? method#3
Open
dantame wants to merge 1 commit intos6577t:masterfrom
Open
Add include_all optional parameter to respond_to? method#3dantame wants to merge 1 commit intos6577t:masterfrom
dantame wants to merge 1 commit intos6577t:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to RSpec 3.0 method_visibility_for has changed the way that it calls to respond_to? internally.
This caused a "Wrong Number of Arguments" error when being called from rspec as the respond_to? method as defined on blobject.rb only accepted one argument and was being passed two.
This patch adds the include_all optional parameter to respond_to? to conform with default ruby respond_to? behaviour.