fix(portfolio): exclude backup evidence from discovery#171
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc51f9c3d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) -> list[SeamLintFinding]: | ||
| exclusions = truth.get("exclusions") | ||
| if not isinstance(exclusions, dict): | ||
| return [ |
There was a problem hiding this comment.
Scan project paths even when exclusions are missing
When contract-shadow checks an artifact that predates or accidentally drops the new exclusions envelope, this early return prevents the later projects[].identity.path scan from running. In that case a truth file can still contain a path like Documents/Codex Backups/..., but CL-EXCL-001 is reported only as an unknown envelope issue so passed remains true instead of rejecting the leaked backup project; scan for leaked excluded path parts before returning for the missing envelope.
Useful? React with 👍 / 👎.
Summary
Verification
Boundaries