chore: deprecate some features #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vijk777
commented
Jan 20, 2026
vijk777
commented
- remove train step evaluation on validation data, it is not needed
- deprecate ems_warmup
- fix validation
validation metrics are now only computed via diagnostics (rollout stats). this removes the redundant per-epoch validation train_step call. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
the ems warmup feature was not being used and added complexity. removed the config field, validation logic, and training loop handling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ochs warmup epochs run before the main training loop and are additional to the configured 'epochs' count. removed misleading validation that required warmup < epochs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.