Skip to content

fix: serve jpeg project favicons with image mime#1

Closed
sabraman wants to merge 1 commit intomainfrom
fix/project-favicon-jpeg-mime
Closed

fix: serve jpeg project favicons with image mime#1
sabraman wants to merge 1 commit intomainfrom
fix/project-favicon-jpeg-mime

Conversation

@sabraman
Copy link
Owner

Summary

  • add .jpeg to the favicon content-type map used by the project favicon proxy
  • add a regression test covering a project icon discovered from HTML metadata

Why

The project favicon route resolves arbitrary rel="icon" hrefs from user projects. When a project used a .jpeg icon, the file could be found and served, but the response fell back to application/octet-stream instead of image/jpeg.

Verification

  • bun run vitest apps/server/src/projectFaviconRoute.test.ts
  • bun fmt
  • bun lint
  • bun typecheck

@sabraman
Copy link
Owner Author

Closing in favor of upstream PR pingdotgg#1313.

@sabraman sabraman closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant