Open
Conversation
added 2 commits
October 30, 2017 09:17
austinhuang0131
commented
Nov 13, 2017
| commentCount: null | ||
| }; | ||
| item.title = $(this).children('.info').children('h3').text().trim(); | ||
| item.title = $(this).children('header').children('a').children('h1.badge-item-title').text().trim(); |
Author
There was a problem hiding this comment.
Title still doesn't work unfortunately
austinhuang0131
commented
Nov 13, 2017
| result.query = query; | ||
| result.sectionHeader = $('div.section-header h3').text(); | ||
| result.result = $('ul.overview-list.badge-entry-collection > li').map(function() { | ||
| result.result = $('div.badge-entry-collection > article').map(function() { |
Author
There was a problem hiding this comment.
Basically copied whatever used in section.js to here
austinhuang0131
commented
Nov 24, 2017
lib/section.js
Outdated
| }; | ||
| item.title = $(this).children('header').children('h2.badge-item-title').children('a').text().trim(); | ||
| item.id = $(this).attr('data-entry-id'); | ||
| item.url = $(this).attr('data-entry-url'); |
Author
There was a problem hiding this comment.
A more convenient way to get URL
added 2 commits
December 6, 2017 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title still doesn't work, however But at least I fixed it from "completely useless" to "somehow useful".