ci: migrate golangci-lint to v2 and re-enable disabled workflows #11
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,48 @@ | ||
| version: "2" | ||
|
|
||
| linters: | ||
| # Default v2 linter set: errcheck, govet, ineffassign, staticcheck, unused. | ||
| # gofmt and goimports moved to formatters in v2 (configured below). | ||
| settings: | ||
| errcheck: | ||
| exclude-functions: | ||
| - (io.Closer).Close | ||
| - (*os.File).Close | ||
| - os.Chmod | ||
| - os.MkdirAll | ||
| - (github.com/sageox/agentx.Registry).Register | ||
| - (*github.com/sageox/agentx.DefaultRegistryImpl).Register | ||
| - (github.com/sageox/agentx.Environment).Remove | ||
| - fmt.Sscanf | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| rules: | ||
| # Test files routinely use Close/Chmod/Register without error checks | ||
| # for setup and cleanup. Those errors aren't actionable in tests. | ||
| - path: _test\.go | ||
| linters: | ||
| - errcheck | ||
| # QF1011 flags `var _ Iface = impl` interface-conformance assertions, | ||
| # but the explicit type is the whole point of the pattern. | ||
| - text: "QF1011" | ||
| linters: | ||
| - staticcheck | ||
|
|
||
| formatters: | ||
| enable: | ||
| - gofmt | ||
| - goimports | ||
| settings: | ||
| goimports: | ||
| local-prefixes: | ||
| - github.com/sageox/agentx | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
|
Comment on lines
+1
to
+48
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify the v2 configuration against golangci-lint's schema
# Check if the config is valid by running golangci-lint with --version to see output
golangci-lint --version 2>/dev/null || echo "golangci-lint not installed in sandbox"
# Look for any example v2 configs or migration documentation in the repo
fd -e yml -e yaml golangci | head -20Repository: sageox/agentx Length of output: 148 🌐 Web query:
💡 Result: No, golangci-lint-action@v6 is not compatible with golangci-lint configuration version 2 format. It is restricted to golangci-lint v1.x versions, which use config version 1.[1][2] Attempting to use golangci-lint v2 (which requires config version: "2"[3][4][5]) with v6 will throw an error: "golangci-lint v2 is not supported by golangci-lint-action v6, you must update to golangci-lint-action v7."[1] v7.0.0 and later support golangci-lint v2 only.[6] The action added JSONSchema verification (default true in later v6 releases), which fails on v2 configs with v1 tooling.[7][8] Citations:
🌐 Web query:
💡 Result: In golangci-lint version 2, the configuration uses YAML format (also supports TOML/JSON). The top-level sections are Citations:
🏁 Script executed: fd -e yml -e yaml | xargs grep -l "golangci-lint-action" 2>/dev/null | head -10Repository: sageox/agentx Length of output: 39 🏁 Script executed: find .github/workflows -type f -name "*.yml" -o -name "*.yaml" 2>/dev/null | xargs cat 2>/dev/null | grep -A2 -B2 "golangci" 2>/dev/null || echo "No workflows found or no golangci references"Repository: sageox/agentx Length of output: 376 Incompatible action version for v2 configuration format. The Update the workflow files to use 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding error checks creates technical debt and potential correctness risks.
The
exclude-functionslist suppresses error checking for operations that can fail in production:os.Chmod,os.MkdirAll- filesystem permission/creation failures(io.Closer).Close,(*os.File).Close- resource cleanup failuresRegistry.Register- registration failuresfmt.Sscanf- parse failuresWhile the PR objectives acknowledge ~30 production-path errcheck warnings are hidden, these exclusions can mask real bugs. For example, unhandled
MkdirAllfailures could lead to subsequent file-write crashes, and ignoredRegistererrors could result in missing agent registrations at runtime.Consider auditing each suppressed case to either explicitly ignore (with inline
_ = ...and comment), propagate errors, or log them. This addresses the technical debt before it compounds.🤖 Prompt for AI Agents