Skip to content

Fix release workflow false-positive change detection#131

Open
luke-hagar-sp wants to merge 1 commit intomainfrom
fix/release-change-detection
Open

Fix release workflow false-positive change detection#131
luke-hagar-sp wants to merge 1 commit intomainfrom
fix/release-change-detection

Conversation

@luke-hagar-sp
Copy link
Contributor

@luke-hagar-sp luke-hagar-sp commented Mar 6, 2026

Summary

  • The check-changes job counted all api-specs commits since the last SDK tag, but daily automated commits (updating dereferenced/ and postman/ files) triggered unnecessary releases every weekday
  • Replace git log --oneline | wc -l with git diff --name-only scoped to idn/**/*.yaml so only actual API spec changes trigger a release
  • Add safe fallback: if the api-specs commit lookup fails, proceed with the release rather than silently skipping

Test plan

  • Verify the workflow syntax is valid (CI should pass)
  • On next scheduled run with no idn/ changes, confirm the workflow logs "No spec file changes" and skips
  • On a run after actual spec changes, confirm it detects the changed files and proceeds

🤖 Generated with Claude Code

@LukasParke @claude
Fix release workflow triggering on non-spec api-specs commits
963d522 
The change detection counted all api-specs commits since the last tag,
but daily automated commits updating dereferenced/ and postman/ files
caused unnecessary releases every weekday. Replace commit-counting with
git diff scoped to idn/**/*.yaml so only actual spec changes trigger
a release.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philip-ellis-sp philip-ellis-sp philip-ellis-sp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luke-hagar-sp @philip-ellis-sp @LukasParke