Skip to content

Warn users not to use broken feature. - #60806

Open
ari wants to merge 2 commits into
saltstack:masterfrom
ari:patch-9
Open

Warn users not to use broken feature.#60806
ari wants to merge 2 commits into
saltstack:masterfrom
ari:patch-9

Conversation

@ari

@ari ari commented Aug 29, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix documention to warn users about long time broken feature.

@ari
ari requested a review from a team as a code owner August 29, 2021 02:12
@ari
ari requested review from Ch3LL and removed request for a team August 29, 2021 02:12

@dwoz dwoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets take #58394 across the finish line instead of merging this.

@ari

ari commented Sep 9, 2021

Copy link
Copy Markdown
Contributor Author

Why? That's a feature that hasn't worked for several years, and no one is interested in reviewing a patch to fix it.

And to top it off its a feature that salt doesn't need because there are other ways to accomplish the same thing. Why is it a loss of face to just admit that it doesn't work and save the next person several wasted hours?

Is the documentation for what salt might be several years from now, or how it works today?

@Ch3LL

Ch3LL commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

@dwoz did you see @ari 's comment here?

@dwoz dwoz self-assigned this Dec 10, 2023
@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
@dwoz
dwoz requested a review from a team as a code owner March 16, 2025 22:09
@twangboy twangboy added the documentation Relates to Salt documentation label Jul 3, 2025
@twangboy twangboy added the pending-discussion The issue or pull request needs more discussion before it can be closed or merged label Jul 3, 2025
@twangboy twangboy modified the milestones: Argon v3008.0, Argon v3008.1 Jun 5, 2026
@dwoz dwoz added the test:full Run the full test suite label Jun 15, 2026
@dwoz dwoz modified the milestones: Argon v3008.1, Potassium v3009.0 Jun 15, 2026
@dwoz

dwoz commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This PR is stale and the original motivation no longer applies.

The PR adds a warning: "Do not use this feature until #58394 is merged." But #58394 was closed without merging in 2021. The underlying sync_after_install immutable-dict bug was fixed independently in May 2022 (commit bb6bcb5, fixing #61946). The feature works today.

The other change (adding all to the list in misc.rst) is redundant — master already has all in that list.

Recommend closing as stale. If any follow-up doc work is needed for sync_after_install, it should be a fresh PR against current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to Salt documentation pending-discussion The issue or pull request needs more discussion before it can be closed or merged test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants