[master] fix ephemeral interface addition - #64584
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
salt-project-bot-prod-environment
Bot
changed the title
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Please create a changelog and a test for this.
twangboy
added
needs-testcase
dwoz
removed
needs-changelog
needs-testcase
Add changelog fragment 64584.fixed.md and unit test test_ephemeral_interface_no_keyerror() covering the case where a network interface appears after LAST_STATS initialization, verifying no KeyError is raised and the new interface fires a beacon event.
3 participants
What does this PR do?
Fixes KeyError exception when a not know interface appears
What issues does this PR fix or reference?
Fixes: test if new interface exists in LAST_DATA if not, creates an empty set to make the diff
Previous Behavior
exception in beacon when new interface appears
New Behavior
beacon executes flawlessly
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.