[master] Make file.manage_file permission, user and group atomic - #65657
[master] Make file.manage_file permission, user and group atomic#65657m-czernek wants to merge 3 commits into
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
294cde5 to
08c1a3e
Compare
|
Please rebase and address conflicts |
|
PR rebased, should be mergeable now. |
|
Test failures |
What does this PR do?
In this PR, I tweak the internal behavior of
file.manage_fileto improve the file permission and owner consistency while the function is executing. See the linked PR for discussion of why this might be useful to users.In the end, while modifying the code, I found this approach to be the simplest and cleanest; however, I am open to discussions and modifying the approach.
What issues does this PR fix or reference?
Fixes: #65651
Previous Behavior
When the module copied a file, the file temporarily used the
600perms with the user of the current running process.New Behavior
Currently, the module attempts to modify the basic file attributes as soon as the file is copied to minimize the risk of race conditions.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes