Set a safe limit to http.client response read #68611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
changed the title
dwoz
changed the title
dwoz
approved these changes
Jan 9, 2026
vzhestkov
pushed a commit
to openSUSE/salt
that referenced
this pull request
Jan 11, 2026
3 tasks
Contributor
It looks like a fix also went into python 3.12 and are targeted to be backported to 3.10 and 3.11 |
m-czernek
added a commit
to openSUSE/salt
that referenced
this pull request
Jan 14, 2026
…7726) (#744) * Fixes for security issues (CVE-2025-67725) httputil: Fix quadratic performance of repeated header lines Previouisly, when many header lines with the same name were found in an HTTP request or response, repeated string concatenation would result in quadratic performance. This change does the concatenation lazily (with a cache) so that repeated headers can be processed efficiently. Security: The previous behavior allowed a denial of service attack via a maliciously crafted HTTP message, but only if the max_header_size was increased from its default of 64kB. * Patch tornado for (BDSA-2025-60811, CVE-2025-67726) httputil: Fix quadratic behavior in _parseparam Prior to this change, _parseparam had O(n^2) behavior when parsing certain inputs, which could be a DoS vector. This change adapts logic from the equivalent function in the python standard library in https://github.com/python/cpython/pull/136072/files * Set a safe limit to http.client response read (CVE-2025-13836) saltstack/salt#68611 * Remove duplicated test --------- Co-authored-by: Twangboy <shane.d.lee@gmail.com> Co-authored-by: Marek Czernek <marek.czernek@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set's a safe limit for the
readfunction of a response fromhttp.clientto avoid DoS through excessive memory allocation. We're doing this because we can't upgrade to Python 3.13.11.Fixes: #68618