Add ssl options to postgres pillar - #68831
Open
dwoz wants to merge 5 commits into
Open
Conversation
themavik
reviewed
Mar 19, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the fix looks correct and follows the existing code patterns.
twangboy
previously approved these changes
Mar 19, 2026
Contributor
|
Looks like psycopg2 is difficult to build on 32bit Windows. The last version of psycopg2-binary that had a 32bit Windows build was 2.9.10. That's why it's failing to build. |
twangboy
previously approved these changes
Jun 30, 2026
The salt_onedir step calls `git add -f salt/_version.txt` with
`cwd=str(salt_archive)`, but `salt_archive` is a path to a `.tar.gz`
file, not a directory. Python's subprocess implementation calls
`chdir()` on `cwd` and raises:
NotADirectoryError: [Errno 20] Not a directory:
'/.../salt-3008.0+NNN.gSHA.tar.gz'
This blocks the Build Salt Onedir job on Linux and macOS, which in
turn cascades to every dependent Build Onedir Packages job.
Use `tools.utils.REPO_ROOT` instead so the subprocess runs in the
salt source checkout, which is a real git repository containing
`salt/_version.txt`. This mirrors the fix already landed on master
in commit eba196e.
twangboy
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #67721