fix: guard against non-iterable target in list_jobs search_target - #68862
Open
joaquinhuigomez wants to merge 3 commits into
Open
fix: guard against non-iterable target in list_jobs search_target#68862joaquinhuigomez wants to merge 3 commits into
joaquinhuigomez wants to merge 3 commits into
Conversation
bdrx312
reviewed
Mar 30, 2026
2 tasks
dwoz
force-pushed
the
fix/list-jobs-search-target-iterable
branch
from
June 7, 2026 06:07
945e742 to
c85f9a6
Compare
When search_target is used in list_jobs, the code assumed Target would always be a string or list. Execution/state failures can leave Target as a non-iterable value (e.g. int), causing a TypeError. Skip non-iterable targets instead of crashing. Closes saltstack#68780
Address review concern: accept any iterable Target (set, dict, etc.) not just list/tuple; only skip and warn on non-iterable scalars like int. Add test covering set-typed Target. Fixes saltstack#68780
dwoz
force-pushed
the
fix/list-jobs-search-target-iterable
branch
from
June 26, 2026 13:03
010ba2a to
1b4be8e
Compare
bdrx312
reviewed
Jul 10, 2026
Comment on lines
+337
to
+344
| elif hasattr(targets, "__iter__"): | ||
| targets = list(targets) | ||
| else: | ||
| log.warning( | ||
| "Job %s has a non-iterable Target value %r; skipping", | ||
| item, | ||
| targets, | ||
| ) |
Contributor
There was a problem hiding this comment.
Maybe just expect type can be converted in the nominal case:
try:
targets = list(targets)
except TypeError:
log.warning(
"Job %s has a non-iterable Target value %r; skipping",
item,
targets,
)
targets = []
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
search_targetis used inlist_jobs, the code assumesTargetis always a string or list. Execution and state failures can leaveTargetas a non-iterable value (e.g. an integer), which causes aTypeErrorwhen iterating.This adds a type check that converts non-iterable, non-string targets to an empty list so they are safely skipped instead of crashing.
Includes a unit test covering the non-iterable target case.
Closes #68780