Skip to content

Unit testing#24

Open
yashwanttejwani wants to merge 9 commits intosamagra-comms:unit-testsfrom
yashwanttejwani:unit-tests
Open

Unit testing#24
yashwanttejwani wants to merge 9 commits intosamagra-comms:unit-testsfrom
yashwanttejwani:unit-tests

Conversation

@yashwanttejwani
Copy link

Reviewer : @surabhi-mahawar

@gitguardian
Copy link

gitguardian bot commented May 2, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret ae81093 src/test/java/com/uci/orchestrator/User/TestConfig.java View secret
- Generic High Entropy Secret aca56e4 src/test/java/com/uci/orchestrator/User/TestConfig.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@yashwanttejwani
Copy link
Author

To-Do in this PR:

  • Mocking of Simple Kafka Producer is remaining.
  • removing the error of log4JAdapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants