Conversation
…ce (Android 9/MediaTek)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across the codebase, with a focus on enhancing compatibility, improving language support, and making service management more robust. The most significant changes include switching all activities to inherit from
AppCompatActivityfor better compatibility, adding a language picker to the settings, and making notification lighting and automation services more reliable across different Android versions.Activity Refactoring and Language Support
MainActivity,SettingsActivity,FeatureSettingsActivity,AppUpdatesActivity,AppLockActivity,LinkPickerActivity) now extendAppCompatActivityinstead ofFragmentActivityorComponentActivity, improving compatibility and support for modern Android features. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]LanguagePicker) to the settings screen, allowing users to select their preferred app language. Also, registered theAppLocalesMetadataHolderServicein the manifest to support locale changes. [1] [2] [3]Bluetooth Permissions and Manifest Updates
AndroidManifest.xmlto include additional Bluetooth permissions with propermaxSdkVersionfor compatibility with Android 12+, ensuring the app can interact with Bluetooth devices across a wider range of devices.Notification Lighting and Automation Service Robustness
NotificationLightingServiceto handle foreground service starts more reliably, using an intent extra (is_foreground_start) to control foreground state and fallback logic for different Android versions and OEM quirks. [1] [2] [3]AutomationManagerto use the same intent extra and added fallback logic for starting services on Android 14+ where background service restrictions are stricter.Notification Listener Improvements
NotificationListenerby introducing agetMediaSessionshelper that gracefully falls back whengetActiveSessionsis restricted, improving reliability for media controls and playback detection. [1] [2] [3]These changes collectively enhance the app's stability, compatibility, and user experience, especially on newer Android versions and in multi-lingual environments.