Added error propagation and project fixes#18
Open
werner77 wants to merge 5 commits intosamskiter:developfrom
Open
Added error propagation and project fixes#18werner77 wants to merge 5 commits intosamskiter:developfrom
werner77 wants to merge 5 commits intosamskiter:developfrom
Conversation
werner77
commented
Mar 7, 2018
werner77
commented
- Added error propagation to be able to inspect the reason of validation failure
- Fixed schema reference resolving: delegate is now called
- Updated project to recommended settings
- Added MacOSX as platform to pod spec
- Added Nullability annotations
- Fixed travis config
- Added MacOSX as platform to pod spec - Added Nullability annotations - Added error propagation to be able to inspect the reason of validation failure
Owner
Author
|
Hi Sam, It's a bit hard to split off the changes after the fact, I could help with the review though? |
Owner
|
Sure, I first want to understand the project changes made if possible. E.g. I'm not sure why the scheme changed... Are you sure they couldn't easily be pulled into their own PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.