Fix GOOS detection and document TOCTOU limitations in pathsafe#9
Merged
sanderhahn merged 4 commits intoself-extracting-examplefrom Feb 13, 2026
Merged
Fix GOOS detection and document TOCTOU limitations in pathsafe#9sanderhahn merged 4 commits intoself-extracting-examplefrom
sanderhahn merged 4 commits intoself-extracting-examplefrom
Conversation
Co-authored-by: sanderhahn <775103+sanderhahn@users.noreply.github.com>
Co-authored-by: sanderhahn <775103+sanderhahn@users.noreply.github.com>
Co-authored-by: sanderhahn <775103+sanderhahn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add examples for self-extracting binaries and update README
Fix GOOS detection and document TOCTOU limitations in pathsafe
Feb 13, 2026
sanderhahn
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses security review feedback from PR #8 regarding platform detection in tests and missing documentation of race condition vulnerabilities in the pathsafe implementation.
Changes
runtime.GOOSinstead ofos.Getenv("GOOS")for reliable platform checks in symlink testspathsafe.SafeJoinandensureNoSymlinkPrefixpathsafeimplementation (replacingfilepath-securejoindependency), security model, and appropriate use casesSecurity Model
The pathsafe package prevents common zip-slip attacks through path validation but cannot eliminate TOCTOU races—an attacker with filesystem access could inject symlinks between validation and file creation. Suitable for trusted extraction environments; hostile scenarios may require additional hardening (e.g., O_NOFOLLOW, destination pre-creation with restrictive permissions).
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.