Skip to content

Y26-084 ultima - added Ultima P3 and P4 tag groups and adjusted sample sheet generator#5630

Merged
yoldas merged 11 commits intodevelopfrom
Y26-084-ultima-support-new-tags-for-ultima-ug200-sequencing-submission
Apr 13, 2026
Merged

Y26-084 ultima - added Ultima P3 and P4 tag groups and adjusted sample sheet generator#5630
yoldas merged 11 commits intodevelopfrom
Y26-084-ultima-support-new-tags-for-ultima-ug200-sequencing-submission

Conversation

@andrewsparkes
Copy link
Copy Markdown
Member

@andrewsparkes andrewsparkes commented Mar 20, 2026

Closes #5620

Changes proposed in this pull request

  • Adds Ultima P3 and P4 tag groups , and adjusts the sample sheet generator

@andrewsparkes andrewsparkes self-assigned this Mar 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.25%. Comparing base (7a04b33) to head (b565ed8).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5630      +/-   ##
===========================================
- Coverage    87.26%   87.25%   -0.02%     
===========================================
  Files         1463     1463              
  Lines        33061    33061              
  Branches      3483     3483              
===========================================
- Hits         28851    28847       -4     
- Misses        4189     4193       +4     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating sample sheet generator too.

@andrewsparkes andrewsparkes changed the title Y26-084 ultima - added Ultima P3 and P3 tag groups and adjusted sample sheet generator Y26-084 ultima - added Ultima P3 and P4 tag groups and adjusted sample sheet generator Mar 23, 2026
@yoldas yoldas requested a review from KatyTaylor April 7, 2026 10:48
Copy link
Copy Markdown
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked tags against Conf page, looks good. Probably don't need to be WIP'd? Having the records in the db shouldn't do any harm?

@yoldas
Copy link
Copy Markdown
Member

yoldas commented Apr 9, 2026

Checked tags against Conf page, looks good. Probably don't need to be WIP'd? Having the records in the db shouldn't do any harm?
Thanks. I think WIP has more benefits. It allows merging early, hides it from production, and avoid changes in production DB in some cases.

@yoldas yoldas merged commit 70091f7 into develop Apr 13, 2026
28 checks passed
@yoldas yoldas deleted the Y26-084-ultima-support-new-tags-for-ultima-ug200-sequencing-submission branch April 13, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-084 - Support New tags for Ultima UG200 sequencing submission

3 participants