Skip to content

Broaden brick/math constraint to support Laravel 13#13

Open
MElkmeshi wants to merge 1 commit intosapientpro:masterfrom
MElkmeshi:l13-compatibility
Open

Broaden brick/math constraint to support Laravel 13#13
MElkmeshi wants to merge 1 commit intosapientpro:masterfrom
MElkmeshi:l13-compatibility

Conversation

@MElkmeshi
Copy link
Copy Markdown

Laravel 13 requires brick/math ^0.14.2+, which conflicts with the previous ^0.12.1 constraint. All BigDecimal API usage is stable across versions, so widening the constraint is safe.

Laravel 13 requires brick/math ^0.14.2+, which conflicts with the
previous ^0.12.1 constraint. All BigDecimal API usage is stable
across versions, so widening the constraint is safe.
@vadymtsots
Copy link
Copy Markdown
Collaborator

@MElkmeshi thanks for the submission!

There is an issue - although the pipelines passed, I tried to run tests using brick/math v 0.17.0 and received an error: Error: Undefined constant Brick\Math\RoundingMode::HALF_UP. The package removed these constants in 0.15.0 and replaced them with PascalCase versions. If you want to support 0.17.0, please update these constants, or remove support of versions higher than 0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants