Skip to content

Optimize FFN size dimension calculation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sashimikun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize FFN size dimension calculation #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions phoenix/grok.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ class TrainingState(NamedTuple):
params: hk.Params


def ffn_size(emb_size, widening_factor):
def ffn_size(emb_size, widening_factor, multiple_of=256):
_ffn_size = int(widening_factor * emb_size) * 2 // 3
_ffn_size = _ffn_size + (8 - _ffn_size) % 8 # ensure it's a multiple of 8
logger.debug(f"emd_size: {emb_size} adjusted ffn_size: {_ffn_size}")
_ffn_size = multiple_of * ((_ffn_size + multiple_of - 1) // multiple_of)
logger.debug(f"emb_size: {emb_size} adjusted ffn_size: {_ffn_size}")
return _ffn_size


Expand Down