refactor: complete M3 migration - fbird_batch_create returns Firebird\BatchHandle#291
Merged
satwareAG-ironMike merged 1 commit intoJul 1, 2026
Conversation
…\BatchHandle (#233) Replace the last RETVAL_RES in the codebase with fbird_setup_batch_object(), returning a Firebird\BatchHandle object instead of a raw resource. All 9 batch consuming functions (fbird_batch_add, _execute, _cancel, _add_blob, _register_blob, _get_blob_alignment, _append_blob_data, _add_blob_stream, _set_default_bpb) updated to dual-accept both Firebird\BatchHandle objects and legacy resources via a new fbird_batch_from_zval() helper. Parameter specs changed from 'r' to 'z' to accept objects. Consistent with all other M3-migrated types (Connection, Transaction, ResultSet, Blob, Event, Service). Closes #233.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233.
Replaces the last
RETVAL_RESin the codebase withfbird_setup_batch_object(). All 9 batch functions updated to dual-accept objects and resources viafbird_batch_from_zval()helper.1 file, +31/-19 lines. Tests: 204 pass / 76 skip / 0 fail.