fix(ci): reliable release pipeline — draft-then-publish architecture#292
Merged
Merged
Conversation
Overhauls the release pipeline to fix all issues encountered during the v11.0.1 release: 1. macOS test-bundles: Fix artifact download pattern (order mismatch) 2. softprops/action-gh-release: Upgrade v2 → v3 in Linux + macOS 3. Windows: Replace raw 'gh release upload' with softprops v3 + draft:true 4. Remove ci-gate jobs (fragile gh run list polling for tag-triggered runs) — replaced by pre-tag verification script (scripts/verify-ci-green.sh) 5. New publish-release.yml: waits for all 3 platform workflows, generates SLSA attestations centrally, then publishes (draft:false) 6. split-stubs: Delete existing tag before re-creating (Option A) 7. scripts/verify-ci-green.sh: Pre-tag CI verification 8. AGENTS.md: Release procedure documentation Architecture: All platform workflows upload with draft:true. The publish-release.yml workflow is the ONLY one that publishes. No race conditions, no 'release not found' errors, no SLSA duplication. Files changed: - .github/workflows/release-linux.yml: -130 lines (ci-gate + SLSA removed) - .github/workflows/release-macos.yml: -106 lines (same + pattern fix) - .github/workflows/release-windows.yml: -99 lines (ci-gate + raw upload removed) - .github/workflows/publish-release.yml: NEW (central publish + SLSA) - .github/workflows/split-stubs.yml: +11 lines (tag deletion step) - scripts/verify-ci-green.sh: NEW - AGENTS.md: +43 lines (release procedure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all release pipeline issues from v11.0.1 release.
Changes
gh release uploadwith softprops v3 +draft: truepublish-release.yml: waits for all 3 platforms, generates SLSA centrally, publishesscripts/verify-ci-green.sh: pre-tag CI verificationAGENTS.md: release procedure documentationArchitecture
All platform workflows upload with
draft: true. Thepublish-release.ymlworkflow is the ONLY one that publishes (draft: false). No race conditions.7 files, +300/-321 lines (net reduction). Code Quality + Sanitizers pass.