Skip to content

Fix release pipeline warnings and add SLSA verification #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satwareAG-ironMike merged 4 commits into from
Jul 2, 2026
Merged

Fix release pipeline warnings and add SLSA verification #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a77e270
fix(windows): remove Unix-style CFLAGS/LDFLAGS causing LNK4044
satwareAG-ironMike Jul 2, 2026
cb58f72
fix(release): upload .md5 checksums, remove per-platform CHECKSUMS
satwareAG-ironMike Jul 2, 2026
9605cf9
fix(ci): bump actions/download-artifact v6 to v7 for Node 24
satwareAG-ironMike Jul 2, 2026
e967e60
feat(ci): add SLSA attestation verification step
satwareAG-ironMike Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,27 @@ jobs:
release-assets/*.tar.gz
release-assets/*.zip

- name: Verify SLSA attestations
run: |
set -e
fail=0
for f in release-assets/*.tar.gz release-assets/*.zip; do
[ -f "$f" ] || continue
echo "Verifying attestation for: $f"
if gh attestation verify "$f" \
--repo "${{ github.repository }}" \
--signer-workflow "${{ github.repository }}/.github/workflows/publish-release.yml"; then
echo " OK"
else
echo " FAILED"
fail=1
fi
done
[ "$fail" -ne 0 ] && exit 1
echo "All release artifacts have verified SLSA provenance attestations"
env:
GH_TOKEN: ${{ github.token }}

- name: Generate checksums index
run: |
cd release-assets
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ jobs:

steps:
- name: Download All Artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7
with:
path: artifacts

Expand Down Expand Up @@ -629,8 +629,8 @@ jobs:
files: |
release-assets/*.tar.gz
release-assets/*.sha256
release-assets/*.md5
release-assets/*.sbom.cdx.json
release-assets/CHECKSUMS-SHA256.txt
fail_on_unmatched_files: false
# Create draft release for tag push (immutable releases)
draft: true
Expand Down Expand Up @@ -670,7 +670,7 @@ jobs:

steps:
- name: Download PHP ${{ matrix.php }} NTS Bundle
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7
with:
pattern: "${{ matrix.bundle_pattern }}"
path: bundle
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ jobs:

steps:
- name: Download All Artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7
with:
path: artifacts

Expand Down Expand Up @@ -490,8 +490,8 @@ jobs:
files: |
release-assets/*.tar.gz
release-assets/*.sha256
release-assets/*.md5
release-assets/*.sbom.cdx.json
release-assets/CHECKSUMS-SHA256.txt
fail_on_unmatched_files: false
draft: true
env:
Expand Down Expand Up @@ -522,7 +522,7 @@ jobs:
echo "PHP version: $(php -v | head -1)"

- name: Download Bundle
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7
with:
pattern: "*macos*${{ matrix.arch }}*"
path: bundle
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/release-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ jobs:
$sdkPath = "C:\firebird-sdk"
echo "FIREBIRD_HOME=$sdkPath" >> $env:GITHUB_ENV
echo "$sdkPath\bin" >> $env:GITHUB_PATH
echo "CFLAGS=-I$sdkPath\include" >> $env:GITHUB_ENV
echo "LDFLAGS=-L$sdkPath\lib" >> $env:GITHUB_ENV

- name: Build Extension
uses: php/php-windows-builder/extension@c49dae50774b14e0f358d2efa65637b67f1104f6 # v1
Expand Down Expand Up @@ -150,7 +148,7 @@ jobs:
fi

- name: Download All Build Artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7
with:
path: artifacts

Expand Down
Loading