Update deprecations and BC breaks and extract strings for translation - #33
Merged
Merged
Conversation
The Stopwatch implementation details tend to obfuscate the benefit of `array_last()`. This is the simplest new feature in PHP 8.5, and it doesn't make sense to give it the most complicated example.
The deprecation for returning a non-string from a user output handler was reverted. Also documented the warning for destructuring non-array values.
This commit does not change any content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the deprecation for returning a non-string from a user output handler, since it was reverted (php/php-src#20455). Also documented the warning for destructuring non-array values.
I also included a commit which reverts to the simpler
array_last()example. IMO the Stopwatch implementation details tend to obfuscate the benefit ofarray_last()rather than helping to highlight it.