deploy: support deploying behind a proxy #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
requested changes
Apr 24, 2025
Collaborator
csegarragonz
left a comment
csegarragonz
left a comment
There was a problem hiding this comment.
Left some comments. Also, make sure you run inv format-code before comitting.
Collaborator
|
Also, I now I said I don't care too much about the commit history, but using it to push changes to the remote machine is maybe a bit too much. Could you rebase and squash all your work commits into one? |
created proxy.py changed sc2.py for more error handling configured proxies, made more reproducible added containerd config fixed cleanup proxies and added configure all fixed cleanup proxy config function unexpected keyword debug fix added /dev/null to sudo tee and debug on for installing bbolt fixing function input quick save disabled proxy cleanup added -e to docker run fixed bbolt install last gcp, now made it reproducible added kubelet drop in proxy conf fixed download binary for recurring install_k8s function bug added additional ips to kubelet no proxy enabled k8s_create debug on added error prints inside turned knative debug on added docker sc2 registry cleanup code added error capture for metalLB in knative installation bypassing webhook validation issues caused by proxy by removing webhook config changed tasks/knative added debug lines in knative added knative manifest patching with proxy variable added kubectl proxy env var setting kubectl proxy doesnt work, patching instead commented out knative manifest change enabled manifest file change again got rid of knative manifest changing again, mightve been *svc increased pod waiting time to 15 secs resetted sleep timer commented out knative install commented out added env var for quay.io added tsak added taskl added debug added debug removed sc2.whatever added new function to proxy.py added ctx param imported it directly into sc2.py for invoke fixed it again printed it in proxy-check changed proxy function, changed install bbolt part, etc named changed so had to change that turned debug on for bbolt got rid of check_return_proxy because it caused errors in bbolt cleaning sc2 for PR cleaned up more fixed dict keys in proxy.conf added proxy config methods fixed docker config dict keys testing out if docker proxy -e really necesary fixed bits here and there testing if we need quay.io builder tag as env var deleted quayio image name changed CSG to SC2 in registry.py
yoshiisato
force-pushed
the
proxy-support-tdx
branch
from
7645ecb to
7815b64
Compare
Collaborator
csegarragonz
left a comment
csegarragonz
left a comment
There was a problem hiding this comment.
It's looking much better now! Just a few comments, and then we'll wait for Knative to be ready.
|
|
||
| run("sudo systemctl daemon-reload", shell=True, check=True) | ||
| run("sudo systemctl restart docker", shell=True, check=True) | ||
| run("sudo systemctl restart docker", shell=True, check=True) |
Collaborator
There was a problem hiding this comment.
@yoshiisato check this diff file. I am pretty sure you need to change the configuration of your text editor.
csegarragonz
changed the title
csegarragonz
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
proxy.pyandproxy.mdto check for pre-existing proxy environment variables and use it to configure containerd, docker, and kubelet services.