Skip to content

Motorola Edge 30 support (motorola-dubai)#30

Open
f-izzo wants to merge 37 commits into
sc7280-mainline:sc7280-7.0.yfrom
f-izzo:sc7280-7.0.y-dubai
Open

Motorola Edge 30 support (motorola-dubai)#30
f-izzo wants to merge 37 commits into
sc7280-mainline:sc7280-7.0.yfrom
f-izzo:sc7280-7.0.y-dubai

Conversation

@f-izzo

@f-izzo f-izzo commented May 30, 2026

Copy link
Copy Markdown

This PR adds support for the Motorola Edge 30 (motorola-dubai).
https://wiki.postmarketos.org/wiki/Motorola_Edge_30_(motorola-dubai)

The actual hardware enablement and mainlining was done by Val Packett.
This is a rebase of the commits from their kernel tree on top of sc7280-7.0.y.

I pulled from LKML the commits already sent upstream and cherry-picked from the tree the others.
The first commits (before 801d836) are necessary backports from LKML, as the code is based on linux-next 20260522.

I tested this on dubai with a postmarketOS edge installation from an unreleased device package and firmware files manually copied to the phone.

Update: camera and audio support were initially broken but are now working on the latest PR version

Works:

  • Boot
  • Screen (panel driver)
  • WiFi / Bluetooth
  • USB

Broken:

  • Cameras
  • Audio (missing UCM profile?)

I'm attaching dmesg from the phone
dmesg-sc7280-rebase.txt

@f-izzo f-izzo changed the title Sc7280 7.0.y dubai Motorola Edge 30 support (motorola-dubai) May 30, 2026
@valpackett

Copy link
Copy Markdown

Broken: Cameras

ultrawide should 100% work

missing UCM profile?

I've posted the link in the matrix group a couple times I think: this gist (not updated for my latest standalone-ification of what was 'q6voiced2' but that's just search&replace) (also "Ass quality Voice." is a silly joke that might not be appropriate for merging :D)

@f-izzo f-izzo force-pushed the sc7280-7.0.y-dubai branch from 50d6ad3 to 5435659 Compare June 1, 2026 09:20
@f-izzo

f-izzo commented Jun 1, 2026

Copy link
Copy Markdown
Author

I removed some unnecessary commits and checked it's still working.

To test I'm using config-postmarketos-qcom-sc7280 defconfig, since that is what will be used in the pmOS package.

For the camera, I was missing CONFIG_VIDEO_AK7375=m for the lens. After adding that, the camera works in Snapshot!

As for audio, I added SND_SOC_WCD937X_SDW=m and your UCM profiles, removing the systemctl calls as dummystreamhack is not yet packaged.

Unfortunately I see only "Dummy device" available in GNOME settings and sound is not working.

Some logs

motorola-dubai:~$ sudo dmesg | grep "sound\|wcd\|aw88"
[    1.310649]   No soundcards found.
[   21.071775] aw88261 1-0034: chip id = 2113
[   21.083451] aw88261 1-0035: chip id = 2113
[   21.509232] qcom-soundwire 3210000.soundwire: din-ports (0) mismatch with controller (1)
[   21.509237] qcom-soundwire 3210000.soundwire: dout-ports (5) mismatch with controller (6)
[   21.633127] qcom-soundwire 3230000.soundwire: din-ports (3) mismatch with controller (4)
[   21.639036] wcd937x_codec audio-codec: bound sdw:2:0:0217:010a:00:4 (ops wcd_sdw_component_ops [snd_soc_wcd_common])
[   21.639064] wcd937x_codec audio-codec: bound sdw:3:0:0217:010a:00:3 (ops wcd_sdw_component_ops [snd_soc_wcd_common])
[   21.648682] aw88261 1-0034: loaded qcom/sm7325/motorola/dubai/aw88261_acf.bin - size: 1944
[   21.690329] aw88261 1-0035: loaded qcom/sm7325/motorola/dubai/aw88261_acf.bin - size: 1944
[   21.833928] aw88261 1-0035: already power off
[   21.835168] aw88261 1-0034: already power off
[   21.837217] input: Motorola-dubai Headset Jack as /devices/platform/sound/sound/card0/input4
[   21.842741] input: Motorola-dubai USB Offload Jack as /devices/platform/sound/sound/card0/input5
[   27.617144] aw88261 1-0035: start failure (-1)
[   27.999839] aw88261 1-0034: start failure (-1)
[   28.074892] aw88261 1-0035: already power off
[   28.076045] aw88261 1-0034: already power off
[   39.525494] aw88261 1-0035: start failure (-1)
[   39.933222] aw88261 1-0034: start failure (-1)
[   39.955740] aw88261 1-0035: already power off
[   39.956937] aw88261 1-0034: already power off
[   42.674857] aw88261 1-0035: start failure (-1)
[   43.165747] aw88261 1-0034: start failure (-1)
[   43.278719] aw88261 1-0035: already power off
[   43.280769] aw88261 1-0034: already power off
motorola-dubai:~$ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: Motoroladubai [Motorola-dubai], device 0: MultiMedia1 (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: Motoroladubai [Motorola-dubai], device 1: MultiMedia2 (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: Motoroladubai [Motorola-dubai], device 2: MultiMedia3 (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0

@f-izzo f-izzo force-pushed the sc7280-7.0.y-dubai branch from 5435659 to e71b0e9 Compare June 2, 2026 15:37
@f-izzo

f-izzo commented Jun 2, 2026

Copy link
Copy Markdown
Author

Ok, after pulling 8515b0a and e3041c7 I can see the HiFi profile in GNOME settings. After rebasing on top of the updated sc7280-7.0.y branch with the FP5 hack reverts, I have finally working audio!

@f-izzo

f-izzo commented Jun 3, 2026

Copy link
Copy Markdown
Author

I added the GC02M1B monochrome camera driver and dts node by Lona and can confirm it's working correctly.

};
};

cam_dvdd0_1p05: dvdd0-1p05-regulator {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reg isn't referenced anywhere, is this actually for the main/selfie cams?

@artlav artlav Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reg isn't referenced anywhere, is this actually for the main/selfie cams?

Yep, this is for the selfie (and main) camera.

};

/*ana*/ldo4 {
cam_avdd2_2p8: ldo4 {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cam_avdd2_2p8 is the only one of the newly-labelled regs used by the depth camera.. Though tbh I probably should have all the labels already in the patch that adds the PMIC

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though tbh I probably should have all the labels already in the patch that adds the PMIC

That's what i figured, so i left the other labels in.

@valpackett

Copy link
Copy Markdown

Cool cool cool. 👍

FWIW Linux 7.1 should release soon, hopefully reducing the need for backports

Srinivas Kandagatla and others added 19 commits June 8, 2026 20:51
…rigger callbacks

The q6asm-dai stream state is used by prepare() to decide whether an
existing stream setup needs to be closed before opening/configuring a new
one. Updating the state from trigger or asynchronous DSP callbacks can make
that state stale or incorrect relative to the actual setup lifetime.

In particular, setting Q6ASM_STREAM_STOPPED on STOP or EOS completion can
make prepare() believe there is no active setup to close, which can result
in opening/configuring the same stream more than once.

Keep stream state updates tied to prepare(), where the stream is actually
closed and reopened, and stop changing it from trigger and EOS callbacks.

Fixes: bfbb12d ("ASoC: qcom: q6asm-dai: perform correct state check before closing")
Cc: Stable@vger.kernel.org
Closes: https://lore.kernel.org/all/afS7rTHdc9TyIeLx@rdacayan/
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260518092347.3446946-2-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
q6asm_dai_close() and q6asm_dai_compr_free() currently issue CMD_CLOSE
whenever prtd->state is non-zero.

After prepare() closes an existing stream, the state is updated to
Q6ASM_STREAM_STOPPED. Since this state is also non-zero, the close and
free paths can send CMD_CLOSE again for a stream that has already been
closed.

Restrict CMD_CLOSE to the Q6ASM_STREAM_RUNNING state so the command is
sent only when the ASM stream is still active.

Fixes: 2a9e92d ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
Cc: Stable@vger.kernel.org
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260518092347.3446946-3-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
…params

Fix error handling in q6asm_dai_compr_set_params() and q6asm_dai_prepare()
for both CMD_CLOSE and q6asm_unmap_memory_regions().

In both the functions, we are doing q6asm_audio_client_free in failure
cases, which means if prepare or set_params fail, we can never recover.
Now open and close are done in respective dai_open/close functions.

Fixes: 2a9e92d ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
Cc: Stable@vger.kernel.org
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260518092347.3446946-4-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
The ASM_CLIENT_EVENT_DATA_WRITE_DONE case does not declare any local
variables or require a separate scope, so drop the unnecessary braces.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260518092347.3446946-5-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Use kzalloc_obj(*prtd) instead of explicitly naming the structure type.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260518092347.3446946-6-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
…ng data

Check widget type before accessing the private data, as this could a
virtual widget which is no associated with a dsp graph, container and
module. Accessing witout check could lead to incorrect memory access.

Fixes: 36ad9bf ("ASoC: qdsp6: audioreach: add topology support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-4-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Add new dai ids entries for LPASS LPI MI2S and SENARY MI2S audio lines.

Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-7-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
lpass ports numbers have been added but the afe/apm driver never got
updated with new max port value that it uses to store dai specific data.
There are more than one places these values are cached and always become
out of sync.

This will result in array out of bounds and weird driver behaviour.

To catch such issues, first add a single place where we can define max
port and second add a check in common parsing code which can error
out before corrupting the memory with out of bounds array access.

This should help both avoid and catch these type of mistakes in future.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-8-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
…S dais

Add support for LPASS LPI MI2S dais in the dai-driver, these dais are
used in Monaco based platform devices.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-9-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Introduces support for the Senary MI2S audio interface in the Qualcomm
q6dsp. Add new AFE port IDs for Senary MI2S RX and TX and include the
necessary mappings in the port configuration  to allow audio routing
over the Senary MI2S interface.

Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Tested-by: Val Packett <val@packett.cool> # sm7325-motorola-dubai
Link: https://patch.msgid.link/20260402081118.348071-10-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Fix the error message to reflect the actual graph stop error
instead of graph close error.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-11-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Start the graph at trigger callback. Staring the graph at prepare does
not make sense as there is no data transfer at this point.
Moving this to trigger will also help cope situation where pipewire
is not happy if display port is not connected during start.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-12-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Remove searching for Shared Memory module instance id on every
read/write call, this is un-necessary if we can cache the shared
memory module instance id per PCM graph.

Add new member to graph struct to store shared memory module
instance id to avoid searching for this in hot path.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260402081118.348071-13-srinivas.kandagatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm
for I2S output.

Signed-off-by: Val Packett <val@packett.cool>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260323095247.92890-1-val@packett.cool
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Add MIPI_DSI_FMT_RGB101010 for 30 bit (10,10,10 RGB) pixel format,
corresponding to the packed 30 bit pixel stream defined in MIPI DSI
v1.3 Section 8.8.17.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Patchwork: https://patchwork.freedesktop.org/patch/713714/
Link: https://lore.kernel.org/r/20260324-dsi-rgb101010-support-v5-1-ff6afc904115@pm.me
[Acked by Maxime to be merged through msm-next on IRC on dri-devel]
[DB: moved RGB101010 to the end of enum mipi_dsi_pixel_format]
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Use default instead of listing unsupported formats explicitly, so the
switch statements don't need updating each time a new pixel format is
added.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Patchwork: https://patchwork.freedesktop.org/patch/713715/
Link: https://lore.kernel.org/r/20260324-dsi-rgb101010-support-v5-2-ff6afc904115@pm.me
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
The MSM8998 DSI controller is v2.0.0 as stated in commit 7b8c9e2
("drm/msm/dsi: Add support for MSM8998 DSI controller"). The value was
always correct just the name was wrong.

Rename and reorder to maintain version sorting.

Fixes: 7b8c9e2 ("drm/msm/dsi: Add support for MSM8998 DSI controller")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Patchwork: https://patchwork.freedesktop.org/patch/713717/
Link: https://lore.kernel.org/r/20260324-dsi-rgb101010-support-v5-3-ff6afc904115@pm.me
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Add a helper for checking if the DSI hardware version is greater
than or equal to a given version, for use in a future change.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Patchwork: https://patchwork.freedesktop.org/patch/713719/
Link: https://lore.kernel.org/r/20260324-dsi-rgb101010-support-v5-4-ff6afc904115@pm.me
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Add video and command mode destination format mappings for RGB101010,
and extend the VID_CFG0 DST_FORMAT bitfield to 3 bits to accommodate
the new format value.

Make sure this is guarded behind MSM_DSI_6G_VER >= V2.1.0 as anything
older does not support this.

Required for 10 bit panels such as the BOE BF068MWM-TD0 found on the
Nothing Phone (3a).

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Patchwork: https://patchwork.freedesktop.org/patch/713721/
Link: https://lore.kernel.org/r/20260324-dsi-rgb101010-support-v5-5-ff6afc904115@pm.me
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
toblux and others added 18 commits June 8, 2026 21:06
Inline i2c_check_functionality() checks, since the function returns a
boolean status rather than an error code.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260329163152.366356-2-thorsten.blum@linux.dev
Signed-off-by: Mark Brown <broonie@kernel.org>
While being less compact, using named initializers allows to more easily
see which members of the structs are assigned which value without having
to lookup the declaration of the struct. And it's also more robust
against changes to the struct definition.

The mentioned robustness is relevant for a planned change to struct
i2c_device_id that replaces .driver_data by an anonymous union.

While touching all these arrays, unify indention and usage of commas.

This patch doesn't modify the compiled arrays, only their representation
in source form benefits. The former was confirmed with x86 and arm64
builds.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/ae2ff4898eb340bd8bcafb7b75443eb4a0ce3e76.1778692164.git.u.kleine-koenig@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
…atch

The response sent by the firmware when requesting a clock vote (opcode
AFE_CMD_RSP_REMOTE_LPASS_CORE_HW_VOTE_REQUEST) does not actually have
the same opcode + status payload as APR_BASIC_RSP_RESULT. Rather, it
returns one single u32 which is the client_handle that must be used in
future unvote requests for the same clock.

As a result of this type confusion, the status returned by the callback
to q6afe_vote_lpass_core_hw was actually an out-of-bounds read. It was
only interpreted as success (0) most of the time due to luck, but there
are some reports of random errors such as:

[   20.961100] qcom-q6afe aprsvc:service:4:4: AFE failed to vote (3)
[   20.961131] Failed to prepare clk 'core': -110

Fix by correctly interpreting the response as a single u32, and actually
store it as the client_handle to ensure unvote would work correctly.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/5976946.DvuYhMxLoT@antlia/
Fixes: 55e0753 ("ASoC: q6dsp: q6afe: add lpass hw voting support")
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Signed-off-by: Val Packett <val@packett.cool>
This commit adds support for senary MI2S mixers.

Signed-off-by: Val Packett <val@packett.cool>
Add support for the SENARY_MI2S_RX DAI which is used on some devices to
send audio data to speaker amplifiers.

Signed-off-by: Val Packett <val@packett.cool>
Modern DSI panels support various modes (resolutions and refresh rates),
which usually requires sending mode-specific DCS commands to configure the
DDIC during operations like prepare(). However existing drm_panel_funcs
only take the panel itself as an argument, so there's no way to access
relevant state (such as the mode being set) inside of these functions.

To allow panel drivers access to the state, introduce new atomic_*
versions of the prepare/enable/disable/unprepare ops, and make the
corresponding drm_panel_* functions call them if available, falling back
to the original ops otherwise. To avoid the need to modify all consumers
at once, the original single-argument drm_panel_* functions are redefined
as aliases to the new ones, passing NULLs for the new extra arguments.

The atomic ops pass the CRTC as well as the atomic state because getting
the mode being set is part of per-CRTC state.

Signed-off-by: Val Packett <val@packett.cool>
As the panel API now includes atomic versions of the power ops, call the
new atomic wrappers in order to allow panel drivers to access CRTC state
like the mode being set.

Signed-off-by: Val Packett <val@packett.cool>
…_name

When setting the model property for the sound card on an OF/DT system,
the expectation is that that model name would be used in the UCM config
path lookup. However, the DT model name was only used as the "short"
name, which gets overriden by the "long" name during loading, and
the "long" name is automatically set based on DMI data if available.
As a result, adding an intermediate bootloader such as U-Boot which
provides DMI data on a device that didn't have it before would break
the UCM config loading by suddenly looking at the "wrong" path.

Fix by assigning the DT model name to the long_name field as well.

Signed-off-by: Val Packett <val@packett.cool>
The Motorola Edge 30 is a smartphone released in 2022.

This commit has the following features working:
- Display (simplefb)
- Touchscreen
- Power and volume buttons
- Storage (UFS 3.1)
- Battery (ADSP battmgr)
- USB (Type-C, 2.0, dual-role)
- Wi-Fi and Bluetooth (WCN6750 hw1.0)

As there are 2 display panel options, prepare for full display support
by creating a common dtsi and per-panel dts files, as is done for
other upstreamed devices.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Val Packett <val@packett.cool>
Add a driver for panels with the NT37701 DDIC, starting with the Tianma
panel (unknown model) used in the Motorola Edge 30 (dubai) smartphone.

Signed-off-by: Val Packett <val@packett.cool>
…XXX]

Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Val Packett <val@packett.cool>
Signed-off-by: Val Packett <val@packett.cool>
Tested on Motorola Edge 30 (motorola-dubai)
Signed-off-by: Lona Lit <artlav@mm.st>
… and dependencies

Signed-off-by: Lona Lit <artlav@mm.st>
@z3ntu z3ntu force-pushed the sc7280-7.0.y-dubai branch from bde22e4 to 4d37f53 Compare June 8, 2026 19:13
@z3ntu

z3ntu commented Jun 8, 2026

Copy link
Copy Markdown
Member

I've marked the patches FROMGIT and FROMLIST where applicable, will take a proper look another time :)

status = "okay";
};

&lpass_rx_macro {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lpass_rx_macro, lpass_tx_macro and lpass_va_macro overrides can be dropped, they have been moved to kodiak.dtsi with "arm64: dts: qcom: kodiak: Elite-ify LPASS macros"

status = "okay";
};

&cci0_i2c1 {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cci0_i2c1 < cci1

remote-endpoint = <&camera_s5kjn1_ep>;
};
};
port@3 {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line between nodes

@z3ntu

z3ntu commented Jun 12, 2026

Copy link
Copy Markdown
Member

Please make sure the wl2864c driver gets upstreamed.

function = "cam_mclk";
drive-strength = <2>;
bias-disable;
};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cam_mclk*_default definitions are now in kodiak.dtsi with the latest commits on the 7.0 branch, so you can drop them here if they're identical.

@valpackett

Copy link
Copy Markdown

Please make sure the wl2864c driver gets upstreamed.

I will, definitely! Sorry, busy with other things, but I'm going to come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants