fix: update for sre extensions#428
Draft
rin-st wants to merge 1 commit into
Draft
Conversation
3 tasks
Member
Author
|
use this branch for testing hh v3 sre challenges migrations @damianmarti |
Collaborator
|
Thanks Rinat makese sense! Let's have both of these changes in SE-2 as well? And then we can backmerge them #427? |
Member
Author
|
Oh, you're right! Created scaffold-eth#1292. Keeping this branch for now for testing sre challenges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to backmerge branch #427
We need those changes for SRE challenges hh v3 migration.
profilesandcompilersin hardhat config. So challenges with override like this become broken https://github.com/scaffold-eth/se-2-challenges/blob/7ff36fa18b7733b7e8ffe55a0325077355bab07b/extension/packages/hardhat/hardhat.config.ts.args.mjs#L3. So just using compilers fixes the issueNote: I still didn't test zk challenge so there's a chance this PR will be updated.Created it so it could be possible to test other challenges migrations