Skip to content

fix: update for sre extensions#428

Draft
rin-st wants to merge 1 commit into
backmerge-20-05-26from
update-for-sre-extensions
Draft

fix: update for sre extensions#428
rin-st wants to merge 1 commit into
backmerge-20-05-26from
update-for-sre-extensions

Conversation

@rin-st

@rin-st rin-st commented May 26, 2026

Copy link
Copy Markdown
Member

PR to backmerge branch #427

We need those changes for SRE challenges hh v3 migration.

  1. Optional but preferred. Reexport artifacts from rocketh file backmerge 22-05-26 (next 16, alchemy key, hardhat v3) #427 (comment)
  2. Hardhat v3 doesnt allow to use both profiles and compilers in hardhat config. So challenges with override like this become broken https://github.com/scaffold-eth/se-2-challenges/blob/7ff36fa18b7733b7e8ffe55a0325077355bab07b/extension/packages/hardhat/hardhat.config.ts.args.mjs#L3. So just using compilers fixes the issue

Note: I still didn't test zk challenge so there's a chance this PR will be updated. Created it so it could be possible to test other challenges migrations

@rin-st

rin-st commented May 26, 2026

Copy link
Copy Markdown
Member Author

use this branch for testing hh v3 sre challenges migrations @damianmarti

@rin-st rin-st requested a review from technophile-04 May 27, 2026 08:12
@technophile-04

Copy link
Copy Markdown
Collaborator

Thanks Rinat makese sense! Let's have both of these changes in SE-2 as well? And then we can backmerge them #427?

@rin-st

rin-st commented May 27, 2026

Copy link
Copy Markdown
Member Author

Oh, you're right! Created scaffold-eth#1292. Keeping this branch for now for testing sre challenges

@rin-st rin-st marked this pull request as draft May 27, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants