Skip to content

replication: Always refresh location data#2705

Closed
delthas wants to merge 2 commits intodevelopment/9.2from
improvement/BB-491/drop-oplog-location
Closed

replication: Always refresh location data#2705
delthas wants to merge 2 commits intodevelopment/9.2from
improvement/BB-491/drop-oplog-location

Conversation

@delthas
Copy link
Contributor

@delthas delthas commented Jan 29, 2026

This is an intermediate step for later removing location data from the Kafka topic (in order to save space).

Issue: BB-491

@bert-e
Copy link
Contributor

bert-e commented Jan 29, 2026

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 29, 2026

Incorrect fix version

The Fix Version/s in issue BB-491 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.2.0

Please check the Fix Version/s of BB-491, or the target
branch of this pull request.

@delthas delthas requested a review from Copilot January 29, 2026 14:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.57%. Comparing base (71c002c) to head (7bb3963).
⚠️ Report is 16 commits behind head on development/9.2.

Files with missing lines Patch % Lines
extensions/replication/tasks/ReplicateObject.js 0.00% 18 Missing ⚠️
extensions/oplogPopulator/OplogPopulator.js 0.00% 3 Missing ⚠️
...ensions/oplogPopulator/pipeline/PipelineFactory.js 0.00% 2 Missing ⚠️
...pulator/pipeline/MultipleBucketsPipelineFactory.js 0.00% 1 Missing ⚠️
...oplogPopulator/pipeline/WildcardPipelineFactory.js 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ns/oplogPopulator/OplogPopulatorConfigValidator.js 100.00% <ø> (ø)
...pulator/pipeline/MultipleBucketsPipelineFactory.js 90.00% <0.00%> (-10.00%) ⬇️
...oplogPopulator/pipeline/WildcardPipelineFactory.js 88.88% <0.00%> (-11.12%) ⬇️
...ensions/oplogPopulator/pipeline/PipelineFactory.js 88.23% <0.00%> (-11.77%) ⬇️
extensions/oplogPopulator/OplogPopulator.js 86.82% <0.00%> (-2.33%) ⬇️
extensions/replication/tasks/ReplicateObject.js 87.26% <0.00%> (-4.55%) ⬇️
Components Coverage Δ
Bucket Notification 80.43% <ø> (ø)
Core Library 80.73% <ø> (ø)
Ingestion 70.31% <ø> (ø)
Lifecycle 78.70% <ø> (ø)
Oplog Populator 83.96% <0.00%> (-1.11%) ⬇️
Replication 60.82% <0.00%> (-0.47%) ⬇️
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.2    #2705      +/-   ##
===================================================
- Coverage            74.72%   74.57%   -0.15%     
===================================================
  Files                  200      200              
  Lines                13488    13507      +19     
===================================================
- Hits                 10079    10073       -6     
- Misses                3399     3424      +25     
  Partials                10       10              
Flag Coverage Δ
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.04% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@delthas delthas force-pushed the improvement/BB-491/drop-oplog-location branch 4 times, most recently from ef65678 to 30c0317 Compare February 3, 2026 11:18
@delthas delthas requested a review from Copilot February 3, 2026 11:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Issue: BB-491
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
@delthas delthas force-pushed the improvement/BB-491/drop-oplog-location branch from 30c0317 to 4c0bd2f Compare February 3, 2026 11:35
@delthas delthas requested a review from Copilot February 3, 2026 11:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This saves space on the Kafka side while preventing a refetch
on most (small) objects.

Issue: BB-491
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
@delthas delthas force-pushed the improvement/BB-491/drop-oplog-location branch from 4c0bd2f to 7bb3963 Compare February 3, 2026 11:52
@delthas delthas closed this Feb 3, 2026
@delthas
Copy link
Contributor Author

delthas commented Feb 3, 2026

Replaced by #2708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants