fix:SP-3857 Fix project license fallback lookup

[agustingroh]

What's Changed

Fixed

• Fixed fallback URL lookup to iterate through all mine IDs

Summary by CodeRabbit

• Bug Fixes
  • Fixed fallback URL lookup mechanism to properly iterate through all available mine identifiers until a valid URL is found, rather than stopping at the first attempt. This improves the reliability and robustness of URL resolution when standard lookup methods fail, ensuring resources can be accessed even in edge cases or complex configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Patches the fallback URL lookup mechanism to iterate through all available mine IDs when searching for URL information, rather than only attempting with the first mine ID. Also updates the changelog with the new patch version 0.12.1 documenting this fix.

Changes

Cohort / File(s)	Summary
Changelog Updates CHANGELOG.md	Added patch version entry 0.12.1 dated 2025-12-23 with fix note about fallback URL lookup iteration. Updated version link references to include ranges for v0.12.0 and v0.12.1.
Fallback URL Lookup Logic pkg/models/all_urls.go	Modified buildFallbackURL function to iterate through all MineIDs instead of using only the first one, calling GetURLFromProject repeatedly until a non-empty license is found, enabling early termination on success.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly relates to the main change: fixing fallback URL lookup to iterate through all mine IDs for resolving project-level licenses.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/empty-project-level-licenses

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

pkg/models/all_urls.go (1)

274-274: Consider removing redundant assignment.

Line 274 assigns mineIds[0] to url.MineID, but the loop on line 275 immediately overwrites it with the first mine ID anyway. This line can be safely removed.

🔎 Proposed simplification

 	}
-	url.MineID = mineIds[0]
 	for _, m := range mineIds {
 		url.MineID = m

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa72c2 and 3a14d86.

📒 Files selected for processing (2)

• CHANGELOG.md
• pkg/models/all_urls.go

🧰 Additional context used

🧬 Code graph analysis (1)

pkg/models/all_urls.go (1)

pkg/models/licenses.go (1)

• License (39-44)

🔇 Additional comments (3)

CHANGELOG.md (2)

12-14: LGTM! Changelog entry is well-documented.

The version entry correctly documents the fix with an appropriate date and clear description.

---

112-113: Version links are correctly updated.

The version comparison ranges are properly configured for the new patch release.

pkg/models/all_urls.go (1)

275-281: Excellent fix! Iterates through all mine IDs correctly.

The loop properly tries each mine ID until a license is found, with efficient early termination. This addresses the PR objective of fixing the fallback URL lookup logic.