Skip to content

added >=py310 compatibility#74

Closed
kylejcaron wants to merge 4 commits into
scientific-python:mainfrom
kylejcaron:python310-compatibility
Closed

added >=py310 compatibility#74
kylejcaron wants to merge 4 commits into
scientific-python:mainfrom
kylejcaron:python310-compatibility

Conversation

@kylejcaron

@kylejcaron kylejcaron commented Aug 12, 2025

Copy link
Copy Markdown

Closes #73.

Release note

For maintainers and optionally contributors, please refer to changelist's README on how to document this PR for the release notes.

Added compatibility for python >= 3.10

@lagru

lagru commented Aug 12, 2025

Copy link
Copy Markdown
Member

Only noticed this after pushing #75. I'll review here.

@lagru

lagru commented Aug 12, 2025

Copy link
Copy Markdown
Member

Let me know when you think it's ready for review.

@kylejcaron kylejcaron marked this pull request as ready for review August 12, 2025 13:19
@kylejcaron

Copy link
Copy Markdown
Author

1 workflow awaiting approval

This workflow requires approval from a maintainer. Learn more about approving workflows.

should be ready for review!

@lagru lagru added the enhancement New feature or functionality label Aug 18, 2025
@lagru

lagru commented Oct 18, 2025

Copy link
Copy Markdown
Member

Hey @kylejcaron, sorry for taking my sweet time coming back to this. I thought about this again and I'd prefer not to add back support for Python 3.10 and 3.11. There are a few reasons for this:

  • Docstub currently does only static analysis. It's therefore very easy to run on projects, even if those only work on older Python versions. That might change if we ever add dynamic analysis.
  • Also after revisiting py312 requirement arviz-devs/arviz-base#87 which I think prompted the related issue and this PR, I don't understand why docstub would constrain arviz-base to Python 3.12 since it's technically a development dependency. I don't think it has to be present during runtime for end users.
  • Having to fallback to using T = TypeVar("T") is actually a bit annoying.
  • As a Scientific Python project it would be nice to follow SPEC 0 in terms of Python support. Nothings forcing us to do so but I think that's probably what most users would assume being the default.
  • Supporting fewer Python versions safes maintainer time and CI resources, even if those savings might not be significant right now. This also follows the sentiment expressed in py312 requirement arviz-devs/arviz-base#87 (comment).

Having said all that, I'm closing this for now. Nevertheless I really appreciate the PR and the work you put in. Sorry for not reaching this opinion earlier.

@lagru lagru closed this Oct 18, 2025
@lagru lagru added the wontfix This will not be worked on label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or functionality wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.10 again?

2 participants