Skip to content

Conversation

@Nydauron
Copy link
Member

Description

Fixes issue regarding the version commit not being shown within the /about response if Pi-Bot was running in a container.

Checks

  • I ran black over the code to ensure formatting.
  • I added docstrings to any new modules, classes, and methods.
  • I updated the docstrings of any updated modules, classes, and methods.
  • I added/updated Python typings for any new/updated class and module.
  • I updated the bot version (if necessary).
  • I ran mypy and reviewed any shown errors related to my changes.

Important Info

  • This pull request adds new pip dependencies.
  • This pull request adds new external dependencies.
  • This pull request changes the required versions of some dependencies.

Issues Closed

My pull request closes the following issues:
N/A

Thank You

Thank you for your contribution to Scioly.org! This pull request will be reviewed
in a promptly manner. If not done, please feel free to contact @cbrxyz.

@Nydauron Nydauron force-pushed the fix/version-commit-not-found-in-container branch from e812de0 to 80b879b Compare August 23, 2025 06:15
@Nydauron
Copy link
Member Author

👍 Works

$ docker run -it ghcr.io/scioly/pi-bot:80b879bcfa599d6519a005fa55246454071a47a6 env
PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=2e0b61f7b55f
TERM=xterm
LANG=C.UTF-8
GPG_KEY=A035C8C19219BA821ECEA86B64E628F8D684696D
PYTHON_VERSION=3.10.18
PYTHON_SHA256=ae665bc678abd9ab6a6e1573d2481625a53719bc517e9a634ed2b9fefae3817f
VERSION_COMMIT=80b879b
HOME=/root

@Nydauron Nydauron merged commit 46edcde into master Aug 23, 2025
3 checks passed
@Nydauron Nydauron deleted the fix/version-commit-not-found-in-container branch August 23, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants