Skip to content

Fix Listen directive to not hard-code IPv4 (fixes #287)#288

Merged
phracek merged 1 commit intosclorg:masterfrom
notroj:fix-issue-287-ipv6-listen
Apr 2, 2026
Merged

Fix Listen directive to not hard-code IPv4 (fixes #287)#288
phracek merged 1 commit intosclorg:masterfrom
notroj:fix-issue-287-ipv6-listen

Conversation

@notroj
Copy link
Copy Markdown
Contributor

@notroj notroj commented Apr 2, 2026 •
edited by github-actions bot
Loading

No description provided.

@notroj @claude
* 2.4/root/usr/share/container-scripts/httpd/common.sh
d9c3857 
  (config_general): Allow listening on both IPv4 and IPv6.
* 2.4-micro/root/usr/share/container-scripts/httpd/common.sh
  (config_general): Likewise.

  Change Listen directives to use port-only format (8080, 8443) instead
  of binding to IPv4-only addresses (0.0.0.0:8080, 0.0.0.0:8443). This
  allows Apache to listen on both IPv4 and IPv6 when available, while
  gracefully handling cases where IPv6 is disabled.

  Fixes: sclorg#287

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026 •
edited
Loading

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Failed

🔴 Pull Request has unsupported target branch master, expected branches are: ''

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean

radekvokal
radekvokal reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown

@radekvokal radekvokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

phracek
phracek approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek
Copy link
Copy Markdown
Member

phracek commented Apr 2, 2026

[test][test-pytest][test-openshift-pytest]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - 2.4-microFedora-latestx86_64✅ passed02.04.2026 13:54:297min 7stest pipeline

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - 2.4Fedora-latestx86_64✅ passed02.04.2026 13:54:306min 46stest pipeline
Fedora - 2.4-microFedora-latestx86_64✅ passed02.04.2026 13:54:316min 33stest pipeline
CentOS Stream 10 - PyTest - 2.4-microCentOS-Stream-10x86_64✅ passed02.04.2026 13:54:319min 36stest pipeline
CentOS Stream 9 - 2.4-microCentOS-Stream-9x86_64✅ passed02.04.2026 13:54:3010min 1stest pipeline
CentOS Stream 9 - PyTest - 2.4-microCentOS-Stream-9x86_64✅ passed02.04.2026 13:54:329min 50stest pipeline
CentOS Stream 10 - 2.4CentOS-Stream-10x86_64✅ passed02.04.2026 13:54:579min 42stest pipeline
CentOS Stream 10 - PyTest - 2.4CentOS-Stream-10x86_64✅ passed02.04.2026 13:54:3010min 21stest pipeline
RHEL8 - 2.4RHEL-8.10.0-Nightlyx86_64✅ passed02.04.2026 13:54:3113min 1stest pipeline
RHEL10 - 2.4RHEL-10.2-Nightlyx86_64✅ passed02.04.2026 13:54:3015min 49stest pipeline
RHEL10 - Unsubscribed host - PyTest - 2.4RHEL-10.2-Nightlyx86_64✅ passed02.04.2026 13:54:3014min 34stest pipeline
RHEL10 - Unsubscribed host - 2.4RHEL-10.2-Nightlyx86_64✅ passed02.04.2026 13:54:3014min 49stest pipeline
RHEL10 - PyTest - 2.4RHEL-10.2-Nightlyx86_64✅ passed02.04.2026 13:54:2915min 11stest pipeline
Fedora - PyTest - 2.4Fedora-latestx86_64✅ passed02.04.2026 14:02:516min 19stest pipeline
RHEL9 - Unsubscribed host - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed02.04.2026 13:54:3017min 29stest pipeline
RHEL9 - Unsubscribed host - PyTest - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed02.04.2026 13:54:3117min 6stest pipeline
RHEL9 - PyTest - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed02.04.2026 13:54:2919min 45stest pipeline
RHEL9 - 2.4RHEL-9.8.0-Nightlyx86_64✅ passed02.04.2026 13:54:3120min 51stest pipeline
RHEL8 - PyTest - 2.4RHEL-8.10.0-Nightlyx86_64✅ passed02.04.2026 14:02:4915min 24stest pipeline
RHEL10 - PyTest - OpenShift 4 - 2.4RHEL-10.2-Nightlyx86_64✅ passed02.04.2026 14:02:5322min 59stest pipeline
RHEL8 - PyTest - OpenShift 4 - 2.4RHEL-8.10.0-Nightlyx86_64❌ error02.04.2026 14:04:5225min 52stest pipeline
RHEL9 - PyTest - OpenShift 4 - 2.4RHEL-9.8.0-Nightlyx86_64❌ error02.04.2026 14:04:5129min 35stest pipeline

@phracek phracek merged commit c5c9b6c into sclorg:master Apr 2, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phracek phracek phracek approved these changes

+1 more reviewer

@radekvokal radekvokal radekvokal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr/needs-manual-merge ready for review READY-to-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notroj @phracek @radekvokal