Skip to content

Update container-common-scripts#220

Merged
phracek merged 1 commit intomasterfrom
update_container_common-scripts
Mar 19, 2026
Merged

Update container-common-scripts#220
phracek merged 1 commit intomasterfrom
update_container_common-scripts

Conversation

@phracek
Copy link
Copy Markdown
Member

@phracek phracek commented Mar 19, 2026

Deliver fix for copying version during the tests

sclorg/container-common-scripts#422

This is needed to have MD files in downstream GitLab repos

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to the latest version.

Deliver fix for copying version during the tests

sclorg/container-common-scripts#422

This is needed to have MD files in downstream GitLab repos

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

The common submodule reference has been updated to point to a different commit hash (bf3bb466... instead of 18f00751...). This changes the underlying code version that the repository depends on without introducing new features or logic changes.

Changes

Cohort / File(s) Summary
Submodule Update
common (submodule pointer)
Updated commit reference from 18f00751b5e5cb1b23c040a20bcf3f65aa667c49 to bf3bb466071024741fdf7a19d64fd394aa994a31.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, a reference updated,
The common ground has now been relocated!
From one commit hash to another we bound,
With whiskers twitching at dependencies found.
✨ Submodules dance—change is complete!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update container-common-scripts' is a vague, generic description that doesn't specify what was actually changed or why the update was needed. Consider using a more descriptive title that explains the purpose of the update, such as 'Fix MD file copying during tests via container-common-scripts update' or 'Update container-common-scripts to include test MD file fix'.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_container_common-scripts
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

@phracek
Copy link
Copy Markdown
Member Author

phracek commented Mar 19, 2026

[test]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 9 - 7CentOS-Stream-9x86_64✅ passed19.03.2026 08:29:179min 42stest pipeline
Fedora - 7Fedora-latestx86_64✅ passed19.03.2026 08:36:186min 59stest pipeline
RHEL9 - Unsubscribed host - 7RHEL-9.6.0-Nightlyx86_64✅ passed19.03.2026 08:31:0714min 27stest pipeline
RHEL8 - 6RHEL-8.10.0-Nightlyx86_64✅ passed19.03.2026 08:39:4919min 20stest pipeline
RHEL9 - 7RHEL-9.6.0-Nightlyx86_64✅ passed19.03.2026 08:41:1122min 14stest pipeline

@phracek phracek merged commit 616771e into master Mar 19, 2026
8 checks passed
@phracek phracek deleted the update_container_common-scripts branch March 19, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant