Remove Ruby container for 3.1. #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove references to that Ruby stream. That version is EOL.
Pull Request validationFailed🔴 Approval - missing or changes were requested Success🟢 CI - All checks have passed |
phracek
requested changes
Jan 13, 2026
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
You have removed the version '3.1' completelly.
What about to update also these two conditions:
- https://github.com/sclorg/s2i-ruby-container/blob/master/test/conftest.py#L55
- https://github.com/sclorg/s2i-ruby-container/blob/master/test/run#L153
Just add '3.3' and more would be fine.
Contributor
Author
Wanted to keep that since its more of a "dependency" check, but it does mean that the related branch on rails-ex can be updated more freely with >= 3.3. Alright. |
Contributor
Author
|
I don't think we can change the 3.1 in bash, and I might've made a mistake when translating the bash here to python. The condition in The bash line is finnicky, I'd rather not edit it, and I'll fixup the python line. |
When translating the bash to python, the bash condition was '<= 3.1', not '< 3.1', therefore the range inversion is '> 3.1'. Since we also removed the 3.1, just bump it properly to '>= 3.3'.
Member
|
Let's test it again. [test-all] |
Testing Farm results
|
phracek
approved these changes
Jan 13, 2026
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
LGTM. The PyTest failures I will solve later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove references to that Ruby stream.
That version is EOL.