Open
Conversation
- Works on any type of object so long as name, attribute, and result are literals - notable case: namedtuples
fixes the messy merge
- so lists/tuples get to keep abc.Sequence semantics - meaning enumerate is now supported
DeepCode's analysis on #79fc9b found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Pull Request Test Coverage Report for Build 116
💛 - Coveralls |
One edge case is when a user subclasses tuple directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #13
support for attribute access of user-defined classes
If it has the attribute and it is a literal, collapse the get attribute
Unrolling and deindexing
namedtupleSupport for enumerate
Before, this only worked for sequences of literals. Now it can combine with deindexing of heterogeneous sequences. It must be in this order of decoration