Update README instructions for version .71.x setup#169
Update README instructions for version .71.x setup#169ajaman190 wants to merge 5 commits intoscorelab:masterfrom
Conversation
shehand
left a comment
shehand
left a comment
There was a problem hiding this comment.
Few more things that I missed previously.
| When contributing to this repository, please first discuss the change you wish to make via issue, | ||
| email, or any other method with the owners of this repository before making a change. |
There was a problem hiding this comment.
I have actually split this line into two steps for better understanding and easy to follow contribution guideline.
There was a problem hiding this comment.
adding a sample contributing guideline for references -> https://github.com/github/docs/blob/main/CONTRIBUTING.md
There was a problem hiding this comment.
I have gone through this sample guideline document, and it seems that the points mentioned there are already covered in the three points I proposed below. These points will be easy to follow for any new contributors.
What do you recommend? Should I elaborate the contribution guideline or keep it concise & easy to follow steps?
There was a problem hiding this comment.
Is this one need to resolve?
|
|
||
| When contributing to this repository, please first discuss the change you wish to make via issue, | ||
| email, or any other method with the owners of this repository before making a change. | ||
| Thank you for your interest in contributing to our project! We welcome all contributions, whether it's a bug fix, feature suggestion, or documentation improvement. |
There was a problem hiding this comment.
I think keeping this, will be appreciate the aspiring contributors as it will help them feel more welcome to this project.
.github/CONTRIBUTING.md
Outdated
| 5. Make your changes and commit them with descriptive commit messages | ||
| 6. Open a `Pull request` from your forked repository to the original repository. [Pull_Request_Template](https://github.com/scorelab/Go-social/blob/14e5dfcdfb59888efc318bb4835e3577d5d09532/.github/PULL_REQUEST_TEMPLATE.md) |
There was a problem hiding this comment.
Combine this. Something like ->
- Commit the changes and open a PR from you fork copy.
There was a problem hiding this comment.
Is this fine?
- Commit your changes with clear messages and open a
Pull Requestfrom your forked repository to the original one for contribution.Pull_Request_Template
|
@Wathsara please take a look into this. Thanks! |
|
Hello @shehand, is there any further changes? |
|
@ajaman190, yes you have not addressed the last comments. Please address them. And you should resolve a conversation once the conversation is actually resolved. |
Which issue is need to be resolve please brief it? I would be glad to address it at the earliest. |
|
@shehand Added the Facebook configuration instructions in the readme.md, please review it. |
2 participants
Updated README.md file #163
Summary:
This pull request involves updates in the setup instructions for the new version of Go-social app.
Issues:
Checklists: