Skip to content

Identified issues of parks Mobile app #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gayanmora wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Identified issues of parks Mobile app #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46863ee
Related if/else if statements should not have the same condition
gayanmora Jun 20, 2020
3fe2d3a
Property names should not be duplicated within a class or object literal
gayanmora Jun 20, 2020
f4a2d0f
Unused assignments should be removed
gayanmora Jun 20, 2020
fabe2ff
Use of a Broken or Risky Cryptographic Algorithm
gayanmora Jun 20, 2020
4d600a2
console log expose sensitive data
gayanmora Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions MobileApp/src/components/FaceBookLogin/FaceBookLogin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ export async function facebookLogin(navigate) {
return
}

console.log(`Login success with permissions: ${result.grantedPermissions.toString()}`);

// get the access token
const data = await AccessToken.getCurrentAccessToken();

Expand All @@ -25,7 +23,6 @@ export async function facebookLogin(navigate) {

// login with credential
await firebase.auth().signInWithCredential(credential).then((user)=>{
console.log(JSON.stringify(user.user.toJSON().uid))
const uid = user.user.toJSON().uid
const name = user.user.toJSON().displayName
const email = user.user.toJSON().email
Expand Down
6 changes: 3 additions & 3 deletions MobileApp/src/components/UserDataHandling/UserDataHandling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export function generateResult(data) {

if (data.sex === 0) {
result.push(['gender-male-female', 'Male']);
} else if (data.sex === 0) {
} else if (data.sex === 1) {
result.push(['gender-male-female', 'Female']);
} else if (data.sex === 0) {
} else if (data.sex === 2) {
result.push(['gender-male-female', 'Both male and female']);
} else {
result.push(['gender-male-female', "Don't know the gender"]);
Expand All @@ -40,7 +40,7 @@ export function generateUUID() {
let uuid = 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function(
c,
) {
let r = (dt + Math.random() * 16) % 16 | 0;
let r = (dt + window.Crypto.getRandomValues(new Uint32Array(1)) * 16) % 16 | 0;
dt = Math.floor(dt / 16);
return (c == 'x' ? r : (r & 0x3) | 0x8).toString(16);
});
Expand Down
2 changes: 0 additions & 2 deletions MobileApp/src/screens/FormScreen/FormScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ class FormScreen extends React.Component {
isAlive: this.state.isAlive,
location: this.state.location,
time: this.state.time,
isAlive: this.state.isAlive,
address: this.state.address,
verified: this.state.verified,
notes: this.state.notes,
park: this.state.park,
Expand Down
1 change: 0 additions & 1 deletion MobileApp/src/screens/ProfileScreen/ProfileScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ class ProfileScreen extends React.Component {

logutHandler = async () => {
await this.closeMenu();
let result = await auth()
.signOut()
.then(() => console.log('Log out'));
};
Expand Down