[UEPR-506] Surprise button not including membership sprites #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test report for scratch-gui 2 files 62 suites 9m 22s ⏱️ Results for commit 8087a87. ♻️ This comment has been updated with latest results. |
KManolov3
reviewed
Feb 9, 2026
| if (this.processedSounds.source === this.props.dynamicSounds) { | ||
| return this.processedSounds.data; | ||
| } | ||
| this.processedSounds = mergeDynamicAssets( |
Contributor
There was a problem hiding this comment.
There is some potential now in passing down the processedSounds to the LibraryComponents, which are children of those containers and use the same logic for mergeDynamicAssets. However, this is more of a nitpick, and I am fine with it being done in another PR.
KManolov3
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Note: Since this branch is based on the latest editor version, which includes a few cherry-picked commits from develop, the commits are also included in this diff. Please check only the last commit for the actual changes.
Reason for Changes
Test Coverage