fix: do not calculate new path in creep.moveTo when creep is fatigued, visualizePathStyle is set, and valid memorized path exists#152
Open
Richard-Krug wants to merge 1 commit intoscreeps:masterfrom
Conversation
…, visualizePathStyle is set, and valid memorized path exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #130
Problem:
Usually,
creep.moveToreturnsC.ERR_TIREDearly when the creep is fatigued. However, whenvisualizePathStyleis set, this does not happen because the path still needs to be visualized. If a valid path is memorized, it is used for the visualization and then formoveByPath. IfmoveByPathsucceeds (C.OK),creep.moveToreturns before a new path is calculated. If the creep is fatigued, however,moveByPathreturnsC.ERR_TIREDand a new path is calculated unnecessarily which wastes a lot of CPU.Solution:
Add
C.ERR_TIREDas a reason to return aftermoveByPathbecause the memorized path is valid and the creep is just fatigued in this case.