Skip to content

chore: DEVPLAT-7373 fix Node.js 20 deprecated GitHub Actions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamranf merged 4 commits into from
May 8, 2026
Merged

chore: DEVPLAT-7373 fix Node.js 20 deprecated GitHub Actions #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f600ce
chore: DEVPLAT-7373 fix Node.js 20 deprecated GitHub Actions
kristianmills May 6, 2026
89fc15b
ci: verify SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC is set before running te…
kristianmills May 6, 2026
1bc7ee7
ci: remove verify-secrets job now that token is confirmed set [DEVPLA…
kristianmills May 6, 2026
66a86b6
fix: token passed
kristianmills May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ jobs:

- name: Semantic Release
id: semantic
uses: cycjimmy/semantic-release-action@v4
uses: cycjimmy/semantic-release-action@v5
Comment thread
kristianmills marked this conversation as resolved.
Copy link
Copy Markdown

@cursor cursor Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary persist-credentials: false added by AI tool

Low Severity

The persist-credentials: false option was added to the checkout step but isn't required for this workflow. As confirmed in the PR discussion, this was introduced by the AI tool (Claude Code) based on a misconception about cycjimmy/semantic-release-action needing it — the official semantic-release docs recommend it, but the cycjimmy wrapper does not, and this repo has never used it. It's harmless but unnecessary, adding noise that may confuse future maintainers about its purpose.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 66a86b6. Configure here.

with:
semantic_version: 24
extra_plugins: |
@semantic-release/changelog@6.0.2
@semantic-release/git@10.0.1
Expand Down
8 changes: 4 additions & 4 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ runs:

- name: Send notification
if: always()
uses: slackapi/slack-github-action@v1.25.0
env:
SLACK_BOT_TOKEN: ${{ inputs.token }}
uses: slackapi/slack-github-action@v3
Comment thread
cursor[bot] marked this conversation as resolved.
with:
channel-id: ${{ inputs.channel }}
method: chat.postMessage
token: ${{ inputs.token }}
payload: |
{
"channel": "${{ inputs.channel }}",
"text": ":${{ steps.fields.outputs.emoji }}: *Workflow <https://github.com/${{ inputs.repository }}/actions/runs/${{ github.run_id }}/|${{ github.workflow }}> ${{ inputs.status }}*",
"attachments": [
{
Expand Down
Loading