Skip to content

Comments

fix: remove unused parameters in co_occurence#1121

Open
selmanozleyen wants to merge 3 commits intoscverse:mainfrom
selmanozleyen:fix/co-occurence-unused-params
Open

fix: remove unused parameters in co_occurence#1121
selmanozleyen wants to merge 3 commits intoscverse:mainfrom
selmanozleyen:fix/co-occurence-unused-params

Conversation

@selmanozleyen
Copy link
Member

fixes: #1110 and #1048 .

n_splits usage was removed here 32789ae

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break code that uses these parameters – sure they are unused, but you could warn first that they do nothing and will be removed, and then remove them later,

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.36%. Comparing base (6dc2a91) to head (7de00ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files          44       44           
  Lines        7132     7132           
  Branches     1212     1212           
=======================================
  Hits         4733     4733           
  Misses       1923     1923           
  Partials      476      476           
Files with missing lines Coverage Δ
src/squidpy/gr/_ppatterns.py 77.92% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused parallelization parameters in co_occurrence

2 participants