Skip to content

Comments

chore: extend the timeout for loky progress init#1124

Merged
selmanozleyen merged 3 commits intoscverse:mainfrom
selmanozleyen:chore/remove-test-parallelize
Feb 24, 2026
Merged

chore: extend the timeout for loky progress init#1124
selmanozleyen merged 3 commits intoscverse:mainfrom
selmanozleyen:chore/remove-test-parallelize

Conversation

@selmanozleyen
Copy link
Member

@selmanozleyen selmanozleyen commented Feb 23, 2026

I added these tests to ensure robustness but I think they are too harsh for parallelize at this point and they just end up being annoying. However I think the fact that a simple test file can break so easily underlines why nobody should use parallelize.

related: #1123

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.36%. Comparing base (26e3ed4) to head (e45d272).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files          44       44           
  Lines        7132     7132           
  Branches     1212     1212           
=======================================
  Hits         4733     4733           
  Misses       1923     1923           
  Partials      476      476           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep removed their request for review February 23, 2026 14:44
@selmanozleyen
Copy link
Member Author

@flying-sheep I checked and the loky process overhead can be like 4 seconds. So I increased the timeout

@selmanozleyen selmanozleyen changed the title chore: remove test_parallelize.py chore: extend the timeout for loky progress init Feb 24, 2026
@flying-sheep
Copy link
Member

ah nice! once you get rid of parallel, you can still get rid of this

@selmanozleyen selmanozleyen merged commit 6dc2a91 into scverse:main Feb 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants