Skip to content

Use idiomatic Python comparison operators in test assertions #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use idiomatic Python comparison operators in test assertions #627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ce257
Initial plan
Copilot Dec 23, 2025
808b799
Apply Python style improvements to test assertions
Copilot Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/integration/standard/test_control_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ def test_get_control_connection_host(self):
"""

host = self.cluster.get_control_connection_host()
assert host == None
assert host is None

self.session = self.cluster.connect()
cc_host = self.cluster.control_connection._connection.host

host = self.cluster.get_control_connection_host()
assert host.address == cc_host
assert host.is_up == True
assert host.is_up

# reconnect and make sure that the new host is reflected correctly
self.cluster.control_connection._reconnect()
Expand All @@ -117,16 +117,16 @@ def test_control_connection_port_discovery(self):
self.cluster = TestCluster()

host = self.cluster.get_control_connection_host()
assert host == None
assert host is None

self.session = self.cluster.connect()
cc_endpoint = self.cluster.control_connection._connection.endpoint

host = self.cluster.get_control_connection_host()
assert host.endpoint == cc_endpoint
assert host.is_up == True
assert host.is_up
hosts = self.cluster.metadata.all_hosts()
assert 3 == len(hosts)
assert len(hosts) == 3

for host in hosts:
assert 9042 == host.broadcast_rpc_port
Expand Down