vector-store: refactor passing memory & worker actors - #536
Merged
ewienik merged 4 commits intoJul 31, 2026
Conversation
Collaborator
Author
|
Changelog for 7aa6712
range diff |
ewienik
marked this pull request as ready for review
July 28, 2026 13:01
As for vector-store::run function we need optional external node_state or db_actor let's refactor it. It will be needed for further commits to allow behind the scene refactors, without exposing actors only for run purpose.
This commit creates memory & worker actor in main run function and pass them to the factories as there ought to be single place to create them. All indexes should use the single worker instance.
Order of creating actors changed. Therefore, some unit tests seem flaky. This commit refactors tests to be more async.
Collaborator
Author
|
Changelog for c20da1a
range diff |
ewienik
force-pushed
the
vector-757-refactor-passing-worker
branch
from
July 30, 2026 10:15
7aa6712 to
c20da1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to have single instance of worker actor - all indexes ought to use it. To be able to provide single instance of worker we need to refactor run function to not provide index factory function.
Additionally this PR adds *.log files to gitignore list.
Fixes: VECTOR-778