Computer Generated Music

[bwerth]

This change is

[rdiverdi]

Review status: 0 of 6 files reviewed at latest revision, 9 unresolved discussions.

---

mp4_music21_rev1.py, line 1 [r7] (raw file):
Header Comment :(
who are you, what are you doing?

---

mp4_music21_rev1.py, line 30 [r7] (raw file):
this would be shorter if it were just:

if dierection == "decending":
    result = result.reverse()
return result

---

mp4_music21_rev1.py, line 52 [r7] (raw file):
repetition

---

mp4_music21_rev1.py, line 54 [r7] (raw file):
There is a lot of code here in the main body of the file. You should have most of this in functions with just a few function calls at the end

---

mp4_music_generation_rev2.py, line 1 [r7] (raw file):
ooo, a header comment

You should remove old versions of code from your github repository before submitting

---

mp4_music_generation_rev2.py, line 18 [r7] (raw file):
This isn't a good place to define a thing, it should be in init as self.note_list (maybe)

---

README, line 1 [r7] (raw file):
Good use of readme, look into markdown for future readmes - Github is set up to work with them very nicely, and they give you lots of nice formatting opitons

---

README, line 4 [r7] (raw file):
links are always useful

---

README, line 6 [r7] (raw file):
that's not not the direction slashes go
Also, this should probably instruct me to clone your repository in my home directory

---

Comments from the review on Reviewable.io